remove zIndex property #4685
Open
remove zIndex property #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaskikutis
approved these changes
Nov 13, 2024
| triggerSelector="#marked-for-desks" | ||
| title={gettext('Marked for')} | ||
| title={gettext('Marked for 123123123')} |
|
did you expose a function from ui-framework to get latest z-index when not using ui-framework components? |
|
but i dont need it for this pr... |
|
How likely it is that someone will need it later? Probably 100% :D Do expose it now(from ui-framework side) so others don't need to later. |
|
but this is ui framework side... i just need to export it.. why is that in relationship with this pr? |
|
do i need to bump version of ui framework again after exporting? |
|
fix ci |
|
@dzonidoo I've restarted unit tests, they do pass now, but there are issues with extensions - do take a look |
|
@tomaskikutis so do i need to reset the failed test? |
|
no, you need to fix the issues with extensions - see logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7429