Add UI feedback #4679
Merged
Add UI feedback #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,7 +114,25 @@ export function HighlightsService(api, $q, $cacheFactory, packages: IPackagesSer | |||
| * Mark an item for a highlight | |||
| */ | |||
| service.markItem = function(highlight, markedItem) { | |||
| return api.save('marked_for_highlights', {highlights: [highlight], marked_item: markedItem._id}); | |||
| dispatchEvent(new CustomEvent('highlights-loading', { | |||
There was a problem hiding this comment.
Can you abstract it into a function so if you want to use it for some other action you would only need to call a function, but wouldn't need to know about events?
function trackArticleActionProgress<T>(p: () => Promise<T>, successMessage: string, errorMessage: string): Promise<T> {
//
}
function markItem(highlight, markedItem) {
return trackArticleActionProgress(
() => api.save(
'marked_for_highlights',
{highlights: [highlight], marked_item: markedItem._id},
),
gettext('Item marked'),
gettext('Couldn\'t mark item'),
);
}
| componentDidMount() { | ||
| addEventListener('highlights-loading', this.handleHighlightsLoading); |
There was a problem hiding this comment.
Let's not couple it to highlights here. Just call it loading indicator. That way we'll be able to reuse it for other actions and will not be lying via naming.
scripts/core/helpers/network.tsx
Outdated
| @@ -173,3 +174,30 @@ export function uploadFileWithProgress<T>( | |||
| }); | |||
| }); | |||
| } | |||
|
|
|||
| export function trackArticleActionProgress<T>( | |||
| p: () => Promise<T>, | |||
There was a problem hiding this comment.
getPromise would be a better name. p was a placeholder in my initial snippet.
scripts/core/helpers/network.tsx
Outdated
| successMessage: string, | ||
| errorMessage: string, | ||
| ): Promise<T> { | ||
| dispatchEvent(new CustomEvent('action-loading', { |
There was a problem hiding this comment.
would be good to call it article-action-loading so if anyone is logging events they would discover quicker from which part is it coming from.
tomaskikutis
approved these changes
Oct 30, 2024
|
cherry pick to release/2.8 and update cp dev |
thecalcc
added a commit
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDCP-854