Add styles for multi column publish tab #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaskikutis
changed the base branch from
develop
to
authoring-react-post-broadcasting
thecalcc
reviewed
Oct 23, 2023
| return assertNever(activeTab); | ||
| function PanelWithHeader({columnCount = 1, children}: {columnCount?: number, children: React.ReactNode}) { | ||
| return ( | ||
| <Panel width={`${40 * columnCount}rem`} markupV2={markupV2} data-test-id="interactive-actions-panel"> |
There was a problem hiding this comment.
what does the 40 mean? Maybe it'd be better to put it in a constant.
Comment on lines
118
to
120
| logger.error(new Error('Publishing multiple items from authoring pane is not supported')); | ||
|
|
||
| return null; |
There was a problem hiding this comment.
Wouldn't it be better to have this show a modal or just something in the UI?
Comment on lines
144
to
147
| if (items.length !== 1) { | ||
| logger.error(new Error('Correcting multiple items from authoring pane is not supported')); | ||
|
|
||
| return null; |
Comment on lines
186
to
205
| } if (activeTab === 'duplicate_to') { | ||
| return ( | ||
| <PanelWithHeader> | ||
| <DuplicateToTab | ||
| items={items} | ||
| closeDuplicateToView={onClose} | ||
| markupV2={markupV2} | ||
| /> | ||
| </PanelWithHeader> | ||
| ); | ||
| } if (activeTab === 'unspike') { | ||
| return ( | ||
| <PanelWithHeader> | ||
| <UnspikeTab | ||
| items={items} | ||
| closeUnspikeView={onClose} | ||
| markupV2={markupV2} | ||
| /> | ||
| </PanelWithHeader> | ||
| ); |
There was a problem hiding this comment.
Was this meant to be else ifs instead of just ifs. If not why?
thecalcc
approved these changes
Oct 26, 2023
tomaskikutis
merged commit db520e7
into
superdesk:authoring-react-post-broadcasting
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7082