Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link shortcut and formatting options zindex fix #4326

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Sep 13, 2023

SDNTB-832

Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify also in the UI that after keybinding gets hit - the keybinding focus goes to link input

@thecalcc
Copy link
Contributor Author

thecalcc commented Sep 13, 2023

verify also in the UI that after keybinding gets hit - the keybinding focus goes to link input

@tomaskikutis
That's not the case even if you click on it with your mouse. This is different because the style of this formatting option is different. Instead it's indicated that this is the formatting option which is active by the popup being displayed.

@thecalcc
Copy link
Contributor Author

@tomaskikutis you'll notice I added the && selectionState.isCollapsed() !== true check. That's because we have to "disable" the possibility to activate the link option if nothing is selected. This is basically mimicking the normal functionality (when clicking on it with your mouse). If there's no text selected we disable the option to add a link.

@thecalcc thecalcc merged commit a679c67 into superdesk:develop Sep 14, 2023
4 of 5 checks passed
@petrjasek petrjasek added this to the 2.6.3 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants