Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z index property #4278

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scripts/apps/search/components/fields/authors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ export class Authors extends SuperdeskReactComponent<IPropsItemListInfo> {
title={gettext('Authors')}
placement="bottom-end"
triggerSelector="#more-authors-button"
zIndex={1031}
>
<table style={{lineHeight: 1.5}}>
<tbody>
Expand Down
3 changes: 1 addition & 2 deletions scripts/apps/search/components/fields/translations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import {gettext, gettextPlural} from 'core/utils';
import {IArticle} from 'superdesk-api';
import {TranslationsListWrapper} from '../translations-list-wrapper';
import {showPopup} from 'core/ui/components/popup';
import {showPopup} from 'superdesk-ui-framework/react/components/ShowPopup';

interface IProps {
item: IArticle;
Expand Down Expand Up @@ -41,7 +41,6 @@ export class Translations extends React.PureComponent<IProps> {
close={closePopup}
/>
),
100,
);
}

Expand Down
4 changes: 2 additions & 2 deletions scripts/core/ArticlesListByQueryWithFilters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export class ArticlesListByQueryWithFilters extends React.PureComponent<IProps,
const sortFilterToolbar = (
<ResizeObserverComponent>
{(dimensions) => (
<SubNav zIndex={4}>
<SubNav>
{getTypeFilteringComponent(dimensions.width < COMPACT_WIDTH)}

<SortBar
Expand Down Expand Up @@ -340,7 +340,7 @@ export class ArticlesListByQueryWithFilters extends React.PureComponent<IProps,
const header = (itemsCount: number): JSX.Element => {
return (
<div data-test-id="articles-list--toolbar">
<SubNav zIndex={5}>
<SubNav>
<div className="space-between">
<h3
className="subnav__page-title sd-flex-no-grow"
Expand Down
122 changes: 0 additions & 122 deletions scripts/core/ui/components/popup.tsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ export class ImageTagging extends React.PureComponent<IProps, IState> {
title={gettext('Information')}
placement="bottom-end"
triggerSelector="#image-suggestions-info-btn"
zIndex={999}
>
{gettext(
'Image suggestions are based on generated tags'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class ManageSetsModalComponent extends React.PureComponent<IProps> {
>
<PageLayout
header={(
<SubNav zIndex={2}>
<SubNav>
<ButtonGroup align="end">
<Button
type="primary"
Expand Down
6 changes: 3 additions & 3 deletions scripts/extensions/sams/src/components/workspaceSubnav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export class WorkspaceSubnavComponent extends React.PureComponent<IProps> {
return (
<React.Fragment>
{(this.props.selectedAssetIds?.length !== 0) ? (
<SubNav zIndex={2}>
<SubNav>
<div className="multi-action-bar">
<button className="toggle" onClick={this.props.closeMultiActionBar}>
<i className="icon-chevron-up-thin" />
Expand Down Expand Up @@ -315,7 +315,7 @@ export class WorkspaceSubnavComponent extends React.PureComponent<IProps> {
</div>
</SubNav>
) : (
<SubNav zIndex={2}>
<SubNav>
<ButtonGroup align="inline">
<Dropdown items={items}>
<button
Expand Down Expand Up @@ -370,7 +370,7 @@ export class WorkspaceSubnavComponent extends React.PureComponent<IProps> {
</ButtonGroup>
</SubNav>
)}
<SubNav zIndex={1}>
<SubNav>
<ButtonGroup align="inline">
<Tooltip
text={gettext('Toggle filters')}
Expand Down
1 change: 0 additions & 1 deletion scripts/validate-instance-configuration.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export function maybeDisplayInvalidInstanceConfigurationMessage() {
visible={true}
headerTemplate={modalHeader}
onHide={closeModal}
zIndex={9999}
>
{issues[0]}
</Modal>
Expand Down