-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label component #723
Open
dzonidoo
wants to merge
12
commits into
superdesk:develop
Choose a base branch
from
dzonidoo:label-component
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Label component #723
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
26a5ad6
created lable component and changed ussages
dzonidoo cbb6504
New navigation (#760)
fritzSF 91acd15
Merge remote-tracking branch 'origin/develop' into new-components
petrjasek 3c07ab3
Implement the new navigation concept for Newshub (#808)
dzonidoo e2b60db
Merge remote-tracking branch 'origin/develop' into new-components
petrjasek 7c81304
Merge branch 'new-components' into label-component
dzonidoo b5014b0
New navigation (#760)
fritzSF 73ca8ba
Implement the new navigation concept for Newshub (#808)
dzonidoo 89f5dd6
fix e2e error
petrjasek efc36f7
Merge remote-tracking branch 'origin/develop' into new-navigation-reb…
petrjasek 0c2ce69
Merge branch 'new-navigation-rebased' into label-component
dzonidoo 21a361a
fix lint
dzonidoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
import ActionButton from 'components/ActionButton'; | ||
|
||
import {Tooltip} from 'bootstrap'; | ||
import {Label} from 'components/Label'; | ||
|
||
function getDeliveryHref(coverage: any) { | ||
return get(coverage, 'delivery_href'); | ||
|
@@ -54,7 +55,7 @@ | |
} | ||
} | ||
|
||
componentWillReceiveProps(nextProps: any) { | ||
Check warning on line 58 in assets/agenda/components/CoverageItemStatus.tsx GitHub Actions / client
|
||
this.setWireItem(nextProps); | ||
} | ||
|
||
|
@@ -188,7 +189,7 @@ | |
|
||
{isCoverageBeingUpdated(coverage) && ( | ||
<div className='coverage-item__row'> | ||
<span className='label label--blue'>{gettext('Update coming')}</span> | ||
<Label text={gettext('Update coming')} type='info' style='translucent' /> | ||
</div> | ||
)} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import * as React from 'react'; | ||
import classNames from 'classnames'; | ||
|
||
interface IProps { | ||
text: string; | ||
type?: 'default' | 'success' | 'warning' | 'alert' | 'info' | 'highlight'; | ||
size?: 'small' | 'medium' | 'big'; | ||
style?: 'fill' | 'hollow' | 'translucent'; // defaults to 'fill' | ||
className?: string; | ||
} | ||
|
||
export class Label extends React.PureComponent<IProps> { | ||
render() { | ||
const classes = classNames('label label--rounded', { | ||
'label--default': !this.props.type, | ||
[`label--${this.props.type}`]: this.props.type !== undefined, | ||
[`label--${this.props.style}`]: this.props.style, | ||
[`label--${this.props.size}`]: this.props.size, | ||
}, this.props.className); | ||
|
||
return ( | ||
<span className={classes}> | ||
{this.props.text} | ||
</span> | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we avoid that?