Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda (Calendar) Location filter improvement [CPCN-935] #1158

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

devketanpro
Copy link
Member

@devketanpro devketanpro commented Nov 12, 2024

Purpose

This PR introduces configurable options for the NewsPro Calendar Location filter, allowing customization of Cities, Places, States, and Countries visibility, as well as the State field label (e.g., "State" or "Province/State").

What has changed

Added configurations:
calendar_location_filter_options: Controls visibility of City, State, Country, and Place.

  • Conditional rendering based on these configs.
  • Places can now be hidden based on settings.

Steps to test

  • Verify the visibility of Cities, Places, and States based on calendar_location_filter_options.

Resolves: #CPCN-935

@petrjasek petrjasek added this to the v2.9 milestone Nov 12, 2024
@petrjasek
Copy link
Member

I would rather use the config on the server side and not generate those aggregations to improve the speed if it won't be used later

newsroom/web/default_settings.py Outdated Show resolved Hide resolved
assets/agenda/components/LocationFilter.tsx Outdated Show resolved Hide resolved
assets/agenda/components/LocationFilter.tsx Outdated Show resolved Hide resolved
assets/agenda/components/LocationFilter.tsx Outdated Show resolved Hide resolved
assets/interfaces/agenda.ts Outdated Show resolved Hide resolved
@devketanpro devketanpro enabled auto-merge (squash) November 13, 2024 10:58
@devketanpro devketanpro merged commit a93479f into superdesk:develop Nov 13, 2024
9 checks passed
@devketanpro devketanpro deleted the CPCN-935 branch November 13, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants