Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mix tasks for generating release artifacts #119

Merged
merged 7 commits into from
Jul 3, 2023
Merged

Conversation

abc3
Copy link
Member

@abc3 abc3 commented Jun 30, 2023

This PR adds new mix tasks that facilitate the generation of release artifacts.

Distillery's implementation is used for generating the appup file and relup is generated via :systools.make_relup/4.

@abc3 abc3 requested a review from chasers June 30, 2023 19:21
@abc3 abc3 marked this pull request as ready for review July 2, 2023 10:38
@abc3 abc3 requested a review from a team July 2, 2023 10:40
Copy link
Contributor

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/tasks/gen.appup.ex Outdated Show resolved Hide resolved
lib/tasks/gen.tarball.ex Outdated Show resolved Hide resolved
lib/tasks/gen.tarball.ex Outdated Show resolved Hide resolved
@josevalim
Copy link
Contributor

Also, for completeness, we talk about the challenges for hot code upgrades here: https://hexdocs.pm/mix/Mix.Tasks.Release.html#module-hot-code-upgrades :)

@abc3
Copy link
Member Author

abc3 commented Jul 3, 2023

@josevalim, thanks for pointing out this notice to me. We want to use the built-in upgrading for minor changes and when it doesn't involve state changes. Our goal is to reduce user disconnection during updates when it is possible

@abc3 abc3 merged commit 313e648 into main Jul 3, 2023
2 checks passed
@abc3 abc3 deleted the feat/release-tasks branch July 3, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants