Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix doubling of rc version identifier #13

Merged
merged 1 commit into from
Jun 13, 2024
Merged

ci: fix doubling of rc version identifier #13

merged 1 commit into from
Jun 13, 2024

Conversation

hf
Copy link
Collaborator

@hf hf commented Jun 12, 2024

When an RC is published on top of an existing RC, the rc identifier doubles. Example from @supabase/auth-js which uses pretty much the same Github Actions workflow file.

The fix is to change the git describe --tags --exclude to a value that actually excludes tags that start with rc.

@hf hf merged commit d01c628 into main Jun 13, 2024
3 checks passed
@hf hf deleted the hf/fix-rc-doubling branch June 13, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants