Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont count Presence state message #643

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix: dont count Presence state message #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1e30a
fix: dont count Presence state message
chasers Aug 22, 2023
6f54f64
fix: actually don't count "presence state" messages now
chasers Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/realtime_web/channels/realtime_channel.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,10 @@ defmodule RealtimeWeb.RealtimeChannel do

@impl true
def handle_info(:sync_presence = msg, %{assigns: %{tenant_topic: topic}} = socket) do
socket = socket |> count() |> maybe_log_handle_info(msg)
# TODO: don't use Presence unless client explicitly wants to use Presence
# TODO: count these again when that happens

socket = socket |> maybe_log_handle_info(msg)

push(socket, "presence_state", presence_dirty_list(topic))

Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Realtime.MixProject do
def project do
[
app: :realtime,
version: "2.21.0",
version: "2.21.1",
elixir: "~> 1.14.0",
elixirc_paths: elixirc_paths(Mix.env()),
start_permanent: Mix.env() == :prod,
Expand Down
Loading