Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

fix: this commit successfully builds the #psql_(14/15)/bin packages #43

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

samrose
Copy link
Collaborator

@samrose samrose commented Feb 15, 2024

What kind of change does this PR introduce?

This PR re-introduces supabase/wrappers back into the build

What is the current behavior?

Including wrappers in build was failing

What is the new behavior?

wrappers may now be included

Additional context

Add any other context or screenshots.

it turns out the cargo-pgrx is at 0.11.0 instead of 0.11.2 at this v0.2.0 point in the supabase/wrappers repo https://github.com/supabase/wrappers/blob/v0.2.0/wrappers/Cargo.lock#L2547

@olirice
Copy link
Collaborator

olirice commented Feb 15, 2024

thanks! can't believe I didn't check that

@olirice olirice merged commit 0c1bc80 into main Feb 15, 2024
1 of 2 checks passed
@olirice olirice deleted the samrose/wrappers-update branch February 15, 2024 16:52
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is it possible to remove this Cargo.lock? Is there a way to get it from upstream?

The drawback of having it is that we're going to keep getting dependabot security updates (and we need to clear this quickly due to a company policy).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steve-chavez seems like it should be possible! I can definitely look into that when I get started

Where do we see the dependabot updates showing up at?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they show up in the security view. you might not have access yet
https://github.com/supabase/nix-postgres/security

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants