Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for remotes when resetting local db #2888

Closed
wants to merge 1 commit into from

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 15, 2024

What kind of change does this PR introduce?

Bug fix #2774

What is the new behavior?

db start | reset should account for remotes declared in config.toml.

[remotes.staging]
project_id = "staging-project-ref"

[remotes.staging.db.seed]
enabled = true
sql_paths = ["seeds/*.sql"]

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11849377517

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 59.634%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11833923706: -0.02%
Covered Lines: 6388
Relevant Lines: 10712

💛 - Coveralls

@sweatybridge sweatybridge deleted the reset-seed branch November 16, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env() does not work in config.toml arrays
2 participants