Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sync smtp and email config to remote #2869

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 11, 2024

What kind of change does this PR introduce?

part 5 of #2814

What is the new behavior?

Syncs email and custom smtp config to remote.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Nov 11, 2024

Pull Request Test Coverage Report for Build 11793949664

Details

  • 13 of 27 (48.15%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.764%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/start/start.go 13 27 48.15%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
internal/start/start.go 9 68.43%
Totals Coverage Status
Change from base Build 11772251670: -0.05%
Covered Lines: 6381
Relevant Lines: 10677

💛 - Coveralls

@sweatybridge
Copy link
Contributor Author

@avallete I'm moving email template to a separate PR because adding Content field also requires updating the local nginx/kong server where these templates are served.

@sweatybridge sweatybridge merged commit 1e5e47b into develop Nov 12, 2024
9 checks passed
@sweatybridge sweatybridge deleted the smtp-config branch November 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants