fix: customAuthHook update REST response #1459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taytzehao
changed the title
|
@kangmingtay , could you or somebody else please help review this PR? |
|
Custom Access Token Hook cannot be used to modify the user metadata, which is common with other similar features in other authentication software. There will be a different hook in the future where you could change the user metadata "before sign up" for example. Custom Access Token hook is therefore not connected to the REST response, as it modifies the access token not the User object. |
|
Thank you for the contribution, though! Please don't feel discouraged to contribute again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The
AuthTokenResponseREST response would be updated with data that is modified by the custom access auth hook.What is the current behavior?
AuthTokenResponseREST response is not updated with data in the custom access auth hook token. #1415What is the new behavior?
The
User_metadatainUserdata of the REST response is in syncuser_metadatain the access token providedAdditional context
Add any other context or screenshots.