Chore: make cookie functions optional in server client #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dijonmusters
commented
Oct 23, 2023
silentworks
approved these changes
Oct 26, 2023
silentworks
reviewed
Oct 26, 2023
dijonmusters
commented
Oct 26, 2023
| remove: (key: string, options?: CookieOptions) => Promise<void> | void; | ||
| }; | ||
| export type BrowserCookieMethods = { | ||
| export type CookieMethods = { |
There was a problem hiding this comment.
Also realised the options parameter should not be optional. Both createServerClient and createBrowserClient pass in the default cookie options when they call these functions
dijonmusters
deleted the
chore/make-cookie-functions-optional-for-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Chore
What is the current behavior?
Cookie functions are mandatory when creating s Server client
What is the new behavior?
Cookie functions are optional when creating s Server client
Additional context
Next.js Server Components cannot set or remove cookies. It doesn't make sense to declare these empty functions to be able to use a Supabase client in a Server Component