Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RealtimeClient endpoint parameter name underscore prefix from initializers #22

Merged

Conversation

foodisbeast
Copy link

What kind of change does this PR introduce?

Removes the _ prefix from the RealtimeClient initializers

What is the current behavior?

RealtimeClient initializer has parameter with underscore prefix

init(_ endpoint: String, ...)

SupabaseClient initializer in main branch of supabase-swift uses endpoint without _ prefix.

/// Realtime client for Supabase
  public var realtime: RealtimeClient {
    RealtimeClient(
      endPoint: realtimeURL.absoluteString,
      params: defaultHeaders
    )
  }

What is the new behavior?

Remove _ prefix from RealtimeClient Initializers.

init(endpoint: String, ...)

Additional context

This fix for #21 should enable usage in current version (0.3.0) of supabase-swift

@grdsdev
Copy link
Contributor

grdsdev commented Aug 1, 2023

Thanks @foodisbeast , but let's keep the initializer and add a new one without the _ and mark it as deprecated.

@foodisbeast
Copy link
Author

Did as you suggested @GRSouza! Reverted previous commit removing _ prefix, and added deprecated initializer matching current usage in supabase-swift v0.3.0 .

@grdsdev grdsdev merged commit bfb5313 into supabase-community:update-upstream Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants