Asking for confirmation, when trying to open more than one tagged thread at once #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, one suggestion though, it is possible to count the messages in the threads too? it is quite a difference if i open 10 threads with 1 message each (which causes 10 messages to be opened) vs opening 5 threads with 10 messages each (which causes 50 messages being opened) |
|
almost, please show the number of messages and threads: do you want to open 5 threads with 50 messages? |
|
code-in task closed: http://www.google-melange.com/gci/task/view/google/gci2014/5800832842858496 |
| total_msg_no = 0 | ||
| threads.each { |t| total_msg_no += t.size } | ||
| if BufferManager.ask_yes_or_no "Are you sure, you want to open #{tagged_no} threads with #{total_msg_no} messages (y/n)?" | ||
| threads.each { |t| select t } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://factor.cc/pad/p/sup-ideas - issue 21
@eMBee ping