Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ran black on NetPyNE #616

Closed
wants to merge 1 commit into from
Closed

ran black on NetPyNE #616

wants to merge 1 commit into from

Conversation

joewgraham
Copy link
Contributor

No description provided.

@joewgraham joewgraham requested a review from salvadord July 8, 2021 18:19
salvadord
salvadord approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@salvadord salvadord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! It almost duplicates the number of lines in the code, but agree that looks cleaner! Hopefully everything keeps working ok :)

@salvadord
Copy link
Collaborator

@joewgraham I was going to merge this but there's 3 conflicts, can you check them please? thx

@lakesare
Copy link

lakesare commented Aug 2, 2021 •
edited
Loading

Just a heads-up - we're going to have 630 conflicts if we merge this PR prior to #623.
We should try to merge #623, and then run black again.

@joewgraham
Copy link
Contributor Author

I am closing this pull request and re-running black on the latest development branch.

@joewgraham joewgraham closed this Aug 4, 2021
@joewgraham joewgraham deleted the blackened branch August 4, 2021 14:50
@lakesare
Copy link

lakesare commented Aug 4, 2021

@joewgraham, my PR isn't merged yet into development!

@joewgraham
Copy link
Contributor Author

I'm looking at your PR now and I'll merge it before I re-run Black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salvadord salvadord salvadord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joewgraham @salvadord @lakesare