-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use only authenticate for create token #819
Open
tomwojcik
wants to merge
14
commits into
master
Choose a base branch
from
feature/#795
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d33c399
rollback 8f65bfff16577c7fb0f52bbabf5fb69f6809ba62, add support for Mo…
tomwojcik 893e0dd
improve test names
tomwojcik ec6a328
Merge branch 'master' into feature/#795
tomwojcik 8d92865
resolve conflicts
tomwojcik e92863f
merge decorators in tests for better readability
tomwojcik eda2cd9
add pytest-mock to test deps
tomwojcik 7bed216
move tests from webauthn to test_webauthn to fix import collision (py…
tomwojcik 95ae2a7
refactor login/username test cases into pytest TestUsernameLoginFields
tomwojcik ccd26cf
fix flaky webauthn test
tomwojcik 8e0af13
Merge branch 'refs/heads/master' into feature/#795
tomwojcik fb084fc
add LoginFieldBackend that allows to log in by LOGIN_FIELD
tomwojcik f2d7dc4
rm commented out test case
tomwojcik bc21dcf
update docs for LOGIN_FIELD
tomwojcik 81cd1e2
add test case for user does not exist in LoginFieldBackend
tomwojcik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
from django.contrib.auth import get_user_model | ||
from django.contrib.auth.backends import ModelBackend | ||
from djoser.conf import settings | ||
|
||
|
||
UserModel = get_user_model() | ||
|
||
|
||
class LoginFieldBackend(ModelBackend): | ||
"""Allows to log in by a different value than the default Django | ||
USERNAME_FIELD.""" | ||
|
||
def authenticate(self, request, username=None, password=None, **kwargs): | ||
if username is None: | ||
username = kwargs.get(UserModel.USERNAME_FIELD) | ||
if username is None or password is None: | ||
return | ||
get_kwargs = { | ||
settings.LOGIN_FIELD: username, | ||
} | ||
try: | ||
user = UserModel._default_manager.get(**get_kwargs) | ||
except UserModel.DoesNotExist: | ||
# Run the default password hasher once to reduce the timing | ||
# difference between an existing and a nonexistent user (#20760). | ||
UserModel().set_password(password) | ||
else: | ||
if user.check_password(password) and self.user_can_authenticate(user): | ||
return user |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.