Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #724 -- I had a bit of fun drafting this.
Requirements considered.
This should be configurable to False if desired (discouraged)Short tokens can never be standalone, otherwise we risk DDoS due to resource exhaustion.my-app://login/<token>
), so it shall not be tied to the general django settings for domain and protocol.django-phonenumber-field
'sPhoneNumberField
, the validation logic should be as reused in the serialiser as possible, through the use of Model serialisers.Todos
How to test:
Request code
Redeem standalone code
Or redeem Short code, that must include the original request data.