fix binomial function in fci_string

sunqm · Mar 1, 2024 · a400640 · a400640
1 parent e2cc8c1
commit a400640
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/pyscf/lib/mcscf/fci_string.c b/pyscf/lib/mcscf/fci_string.c
@@ -130,12 +130,7 @@ static int binomial(int n, int m)
                 if (m*2 <= n) {
                         m = n - m;
                 }
-                uint64_t i;
-                uint64_t val = 1;
-                for (i = m; i <= n; i++) {
-                        val *= i;
-                        val /= i - m;
-                }
+		int val = binomial(n-1,m-1) + binomial(n-1,m);
                 return val;
         }
 }