Fix checksum calculation for B64/Z64 encoded bitmap data (#41)

* Use correct polynomial and encode CRC as hexadecimal * Change algorithm for CRC * Update B64/Z64 checksums in unit tests
sungaila · Dec 14, 2023 · eb918f0 · eb918f0
1 parent 5078242
commit eb918f0
Show file tree

Hide file tree

Showing 11 changed files with 338 additions and 362 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -12,7 +12,7 @@ body:
     attributes:
       label: PDFtoZPL version
       description: Which version of PDFtoZPL is affected?
-      value: 3.6.3
+      value: 3.6.4
     validations:
       required: true
   - type: dropdown

diff --git a/Console/Console.csproj b/Console/Console.csproj
@@ -6,7 +6,7 @@
     <AssemblyName>PDFtoZPL.Console</AssemblyName>
     <RootNamespace>PDFtoZPL.Console</RootNamespace>
     <StartupObject>PDFtoZPL.Console.Program</StartupObject>
-    <Version>3.6.3</Version>
+    <Version>3.6.4</Version>
     <Configurations>Debug;Release;ReleaseSigned</Configurations>
   </PropertyGroup>
 

diff --git a/PDFtoZPL/Conversion.cs b/PDFtoZPL/Conversion.cs
@@ -579,9 +579,9 @@ private static string ConvertBitmapImpl(SKBitmap pdfBitmap, BitmapEncodingKind e
 					}
 
 					var base64 = Convert.ToBase64String(bitmapAsBytes);
-					var csc = ComputeBitmapChecksum(base64);
+					ushort csc = ComputeBitmapChecksum(base64);
 
-					bitmapPayload = $":{encodingId}:{base64}:{csc}";
+					bitmapPayload = $":{encodingId}:{base64}:{csc:X4}";
 				}
 				else
 				{