Skip to content

Commit

Permalink
lint and api extract fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sundersc committed Sep 19, 2023
1 parent 8cd3b26 commit 3683e2a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ export class DefaultValueTransformer extends TransformerPluginBase {
const context = ctx as TransformerContextProvider;

for (const typeName of this.directiveMap.keys()) {

// Set the default value only for DDB datasource. For RDS, the database will set the value.
const isDynamoDB = isDynamoDBDatasource(ctx, typeName);
if (!isDynamoDB) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1593,14 +1593,14 @@ describe('ModelTransformer:', () => {
subnetAvailabilityZoneConfig: [
{
SubnetId: 'sub-123',
AvailabilityZone: 'az-123'
AvailabilityZone: 'az-123',
},
{
SubnetId: 'sub-456',
AvailabilityZone: 'az-456'
AvailabilityZone: 'az-456',
},
],
}
};
const out = testTransform({
schema: validSchema,
transformers: [new ModelTransformer()],
Expand All @@ -1619,12 +1619,8 @@ describe('ModelTransformer:', () => {
expect(sqlLambda.Properties).toBeDefined();
expect(sqlLambda.Properties?.VpcConfig).toBeDefined();
expect(sqlLambda.Properties?.VpcConfig?.SubnetIds).toBeDefined();
expect(sqlLambda.Properties?.VpcConfig?.SubnetIds).toEqual(
expect.arrayContaining(['sub-123', 'sub-456']),
);
expect(sqlLambda.Properties?.VpcConfig?.SubnetIds).toEqual(expect.arrayContaining(['sub-123', 'sub-456']));
expect(sqlLambda.Properties?.VpcConfig?.SecurityGroupIds).toBeDefined();
expect(sqlLambda.Properties?.VpcConfig?.SecurityGroupIds).toEqual(
expect.arrayContaining(['sg-123']),
);
expect(sqlLambda.Properties?.VpcConfig?.SecurityGroupIds).toEqual(expect.arrayContaining(['sg-123']));
});
});
2 changes: 2 additions & 0 deletions packages/amplify-graphql-transformer-test-utils/API.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import type { SynthParameters } from '@aws-amplify/graphql-transformer-interface
import { TransformerPluginProvider } from '@aws-amplify/graphql-transformer-interfaces';
import type { TransformParameters } from '@aws-amplify/graphql-transformer-interfaces';
import { UserDefinedSlot } from '@aws-amplify/graphql-transformer-core';
import type { VpcSubnetConfig } from '@aws-amplify/graphql-transformer-interfaces';

// @public (undocumented)
export interface AmplifyApiGraphQlResourceStackTemplate {
Expand Down Expand Up @@ -141,6 +142,7 @@ export type TestTransformParameters = {
datasourceSecretParameterLocations?: Map<string, RDSConnectionSecrets>;
customQueries?: Map<string, string>;
overrideConfig?: OverrideConfig;
sqlLambdaVpcConfig?: VpcSubnetConfig;
};

// @public (undocumented)
Expand Down

0 comments on commit 3683e2a

Please sign in to comment.