This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
<DRAFT> Insert table as select #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgkiran
reviewed
Sep 24, 2024
| @@ -1313,6 +1313,22 @@ substrait::Rel *DuckDBToSubstrait::TransformGet(LogicalOperator &dop) { | |||
| return get_rel; | |||
| } | |||
|
|
|||
| static substrait::Expression_Literal GetLiteralFromSubstraitExpression(const substrait::Expression &expr) { | |||
There was a problem hiding this comment.
can you make this a class member?
substrait::Expression_Literal DuckDBToSubstrait::ToExpressionLiteral
scgkiran
reviewed
Sep 24, 2024
| @@ -1431,8 +1568,24 @@ static bool IsSetOperation(const LogicalOperator &op) { | |||
| op.type == LogicalOperatorType::LOGICAL_INTERSECT; | |||
| } | |||
|
|
|||
| static bool IsWriteORUpdateOperation(const LogicalOperator &op) { | |||
| switch (op.type) | |||
| { | |||
There was a problem hiding this comment.
nit: code style mismatch. { should be in the same line as switch.
|
This is covered in #9 . So closing this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Insert from select
-- insert from virtual table
-- select from virtual table