This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Update Proto Source files with latest proto definitions #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshuldata
commented
Nov 4, 2024
anshuldata
commented
- Fixed name of Join type (it was a breaking change in substrait)
* This will get virtual table expression
EpsilonPrime
reviewed
Nov 4, 2024
EpsilonPrime
approved these changes
Nov 4, 2024
anshuldata
force-pushed
the
anshul/ProtoUpdate
branch
from
2dd38c0 to
ab07539
Compare
|
missed adding missing join to file to_substrait. Update now. Can you re-approve @EpsilonPrime |
|
@EpsilonPrime I don't have write access to this branch. please merge this. |
anshuldata
added a commit
to anshuldata/duckdb-substrait-extension
that referenced
this pull request
Nov 6, 2024
…eck-io#12)" This reverts commit ec315b6.
anshuldata
added a commit
to anshuldata/duckdb-substrait-extension
that referenced
this pull request
Nov 8, 2024
* Fixed name of Join type (it was a breaking change in substrait) (cherry picked from commit ec315b6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.