Address review comments

sundeck-io · Sep 26, 2024 · 090c168 · 090c168
1 parent 1683e78
commit 090c168
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/from_substrait.cpp b/src/from_substrait.cpp
@@ -732,7 +732,7 @@ shared_ptr<Relation> SubstraitToDuckDB::TransformRootOp(const substrait::RelRoot
 		case substrait::WriteRel::WriteOp::WriteRel_WriteOp_WRITE_OP_CTAS: {
 			const auto create_table = static_cast<CreateTableRelation *>(child.get());
 			auto proj = make_shared_ptr<ProjectionRelation>(create_table->child, std::move(expressions), aliases);
-			return proj->CreateRel(create_table->schema_name, create_table->table_name, false);
+			return proj->CreateRel(create_table->schema_name, create_table->table_name);
 		}
 		default:
 			return child;

diff --git a/test/python/test_substrait.py b/test/python/test_substrait.py
@@ -24,7 +24,7 @@ def test_ctas_with_select_columns(require):
         SELECT name, salary FROM employees""")
 
     expected = pd.DataFrame({"name": ["John Doe", "Jane Smith", "Alice Johnson", "Bob Brown", "Charlie Black"],
-                             "salary": [120000.0, 80000, 50000, 95000, 60000]})
+                             "salary": pd.Series([120000, 80000, 50000, 95000, 60000], dtype="float64")})
 
     query_result = execute_via_substrait(connection, "SELECT * FROM employee_salaries")
     pd.testing.assert_frame_equal(query_result.df(), expected)
@@ -39,7 +39,7 @@ def test_ctas_with_filter(require):
     expected = pd.DataFrame({"employee_id": pd.Series([1, 4], dtype="int32"),
                              "name": ["John Doe", "Bob Brown"],
                              "department_id": pd.Series([1, 3], dtype="int32"),
-                             "salary": [120000.0, 95000]})
+                             "salary":  pd.Series([120000, 95000], dtype="float64")})
 
     query_result = execute_via_substrait(connection, "SELECT * FROM high_earners")
     pd.testing.assert_frame_equal(query_result.df(), expected)
@@ -73,7 +73,7 @@ def test_ctas_with_order_by(require):
     expected = pd.DataFrame({"employee_id": pd.Series([1, 4, 2, 5, 3], dtype="int32"),
                              "name": ["John Doe", "Bob Brown", "Jane Smith", "Charlie Black", "Alice Johnson"],
                              "department_id": pd.Series([1, 3, 2, 2, 1], dtype="int32"),
-                             "salary": [120000.0, 95000, 80000, 60000, 50000]})
+                             "salary":  pd.Series([120000, 95000, 80000, 60000, 50000], dtype="float64")})
 
     query_result = execute_via_substrait(connection, "SELECT * FROM sorted_employees")
     pd.testing.assert_frame_equal(query_result.df(), expected)
@@ -90,7 +90,7 @@ def test_ctas_with_subquery(require):
     """)
 
     expected = pd.DataFrame({"employee_id": pd.Series([1], dtype="int32"),
-                             "name": ["John Doe"], "salary": [120000.0]})
+                             "name": ["John Doe"], "salary":  pd.Series([120000], dtype="float64")})
     query_result = execute_via_substrait(connection, "SELECT * FROM high_salary_employees")
     pd.testing.assert_frame_equal(query_result.df(), expected)
 
@@ -146,7 +146,7 @@ def test_ctas_with_union(require):
                              "name": ["John Doe", "Jane Smith", "Alice Johnson", "Bob Brown", "Charlie Black",
                                       "David White", "Eve Green"],
                              "department_id": pd.Series([1, 2, 1, 3, 2, 1, 2], dtype="int32"),
-                             "salary": [120000.0, 80000, 50000, 95000, 60000, 30000, 40000]})
+                             "salary":  pd.Series([120000, 80000, 50000, 95000, 60000, 30000, 40000], dtype="float64")})
 
     query_result = execute_via_substrait(connection, "SELECT * FROM all_employees")
     pd.testing.assert_frame_equal(query_result.df(), expected)