Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak design of form fields #2101

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Tweak design of form fields #2101

wants to merge 2 commits into from

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented May 11, 2023

Addresses #ticket-number.

Purpose

As part of the one design language (ODL) project, we've reviewed the form components and tweaked their styles to improve their cohesiveness and visual hierarchy.

Approach and changes

  • Change the label's and validation hint's font-weight from regular to bold
  • Increase the input border-radius from 8px to 12px
  • Change the error icon from the Alert to the Notify icon

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

⚠️ No Changeset found

Latest commit: 5fee865

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 4:13pm

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2101 (5fee865) into main (eb445e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2101   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         170      170           
  Lines        3599     3600    +1     
  Branches     1267     1267           
=======================================
+ Hits         3314     3315    +1     
  Misses        264      264           
  Partials       21       21           
Impacted Files Coverage Δ
packages/circuit-ui/components/Input/Input.tsx 93.47% <ø> (ø)
.../circuit-ui/components/SearchInput/SearchInput.tsx 81.25% <ø> (ø)
packages/circuit-ui/components/Select/Select.tsx 95.12% <ø> (ø)
...ckages/circuit-ui/components/Selector/Selector.tsx 90.24% <ø> (ø)
...ircuit-ui/components/FieldAtoms/FieldLabelText.tsx 90.90% <100.00%> (+0.90%) ⬆️
...t-ui/components/FieldAtoms/FieldValidationHint.tsx 94.59% <100.00%> (ø)

@connor-baer
Copy link
Member Author

connor-baer commented Jun 12, 2023

This change has been postponed until after v7 v8 to align the rollout with the mobile apps.

@connor-baer connor-baer modified the milestones: v6.x, v7.0, v7.x Jun 12, 2023
@connor-baer connor-baer modified the milestones: v7.x, v8.x, v9 Feb 9, 2024
@connor-baer connor-baer modified the milestones: v9, v10 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂 circuit-ui 🎨 design Requires input from designers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant