chore: add audit comments #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxkzmn
reviewed
Oct 31, 2023
| @@ -77,6 +89,9 @@ contract Summa is Ownable { | |||
| ); | |||
| uint256 index = ownershipProofByAddress[addressHash]; | |||
| require(index == 0, "Address already verified"); | |||
| /* | |||
| Is there any reason to assign value `i + 1` to `ownershipProofByAddress[addressHash]`? | |||
There was a problem hiding this comment.
The idea was to store the array index, but starting with 1 allows to distinguish a case when the proof has not yet been submitted (the storage slots are zero by default).
enricobottazzi
pushed a commit
that referenced
this pull request
Nov 8, 2023
* chore: add audit comments (#168) * Refactor backend by following internal audit comments (#173) * feat: create bash script for updating verifier interface files in backend * fix: error propagation with try operator; remove unnecessaries * refactor: changed data type in 'MstInclusionProof' * fix: generate solvency verifier contract * chore: remove left over * chore: update README * fix: remove left over; assert term * fix: update README; small fixes * feat: Signer accepts address or file path for init * Refactor contract according to V1 consolidation spec (#169) * Refactor smart contract * Update smart contract module readme --------- Co-authored-by: JinHwan <[email protected]>
enricobottazzi
added a commit
that referenced
this pull request
Nov 10, 2023
* chore: add audit comments (#168) * Refactor backend by following internal audit comments (#173) * feat: create bash script for updating verifier interface files in backend * fix: error propagation with try operator; remove unnecessaries * refactor: changed data type in 'MstInclusionProof' * fix: generate solvency verifier contract * chore: remove left over * chore: update README * fix: remove left over; assert term * fix: update README; small fixes * feat: Signer accepts address or file path for init * feat: added mutex lock to signer; used it as ref * fix: mutex deadlock in signer * chore: minor updates * feat: `Tree` trait * fix: move `verify_proof` logic to `Tree` trait * feat: added method implementation to `Tree` trait and moved outside of utils * refactor: signer spawn provider internally; updated comments * fix: round now use Tree trait * refactor: Round needs MST and Assets instead of csv files path * fix: rollback applying csv_parser for AddressOwnership and Assets in Snapshot * fix: Solvency::init fn accept type that has Tree trait * fix: updates for summa solvency contract v1.1 * chore: rename `compute_leaves` api * fix: Rounds accept 'Tree' trait object * chore: removed and updated comments * chore: removed env variables 'SIGNATURE_VERIFICATION_MESSAGE' --------- Co-authored-by: JinHwan <[email protected]> Co-authored-by: sifnoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.