opt: add support for CREATE TRIGGER in optimizer

This commit finalizes support for `CREATE TRIGGER` by adding support for it in the optimizer. This includes validation for the statement, dependency resolution, and logic tests. Fixes cockroachdb#126359 Release note (sql change): Added support for CREATE TRIGGER. Note that OR REPLACE syntax is not yet supported. Also note that triggers cannot yet be executed, so creation is currently a no-op.
sumeerbhola · Oct 12, 2024 · 0b647ac · 0b647ac
1 parent 9fb8eeb
commit 0b647ac
Show file tree

Hide file tree

Showing 48 changed files with 2,843 additions and 60 deletions.
diff --git a/pkg/ccl/logictestccl/testdata/logic_test/triggers b/pkg/ccl/logictestccl/testdata/logic_test/triggers
diff --git a/pkg/ccl/logictestccl/tests/local-legacy-schema-changer/BUILD.bazel b/pkg/ccl/logictestccl/tests/local-legacy-schema-changer/BUILD.bazel
@@ -9,7 +9,7 @@ go_test(
  "//pkg/ccl/logictestccl:testdata", # keep
  ],
  exec_properties = {"test.Pool": "large"},
- shard_count = 30,
+ shard_count = 29,
  tags = ["cpu:1"],
  deps = [
  "//pkg/base",

diff --git a/pkg/ccl/logictestccl/tests/local-legacy-schema-changer/generated_test.go b/pkg/ccl/logictestccl/tests/local-legacy-schema-changer/generated_test.go
diff --git a/pkg/ccl/logictestccl/tests/local-mixed-24.1/BUILD.bazel b/pkg/ccl/logictestccl/tests/local-mixed-24.1/BUILD.bazel
@@ -9,7 +9,7 @@ go_test(
  "//pkg/ccl/logictestccl:testdata", # keep
  ],
  exec_properties = {"test.Pool": "large"},
- shard_count = 29,
+ shard_count = 28,
  tags = ["cpu:1"],
  deps = [
  "//pkg/base",

diff --git a/pkg/ccl/logictestccl/tests/local-mixed-24.1/generated_test.go b/pkg/ccl/logictestccl/tests/local-mixed-24.1/generated_test.go
diff --git a/pkg/ccl/logictestccl/tests/local-mixed-24.2/BUILD.bazel b/pkg/ccl/logictestccl/tests/local-mixed-24.2/BUILD.bazel
@@ -9,7 +9,7 @@ go_test(
  "//pkg/ccl/logictestccl:testdata", # keep
  ],
  exec_properties = {"test.Pool": "large"},
- shard_count = 30,
+ shard_count = 29,
  tags = ["cpu:1"],
  deps = [
  "//pkg/base",

diff --git a/pkg/ccl/logictestccl/tests/local-mixed-24.2/generated_test.go b/pkg/ccl/logictestccl/tests/local-mixed-24.2/generated_test.go