Replace loading auto with img loading attribute (#41)

sulu · Jan 24, 2022 · bdb1c6d · bdb1c6d
1 parent 8a02571
commit bdb1c6d
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/src/ImageExtension.php b/src/ImageExtension.php
@@ -378,6 +378,8 @@ private function createTag(string $tag, array $attributes, array $thumbnails, ?a
 
  // Replace thumbnail format in srcset.
  $value = $this->srcsetThumbnailReplace($value, $thumbnails);
+ } elseif ('loading' === $key && 'auto' === $value) {
+ continue;
  }
 
  $output .= sprintf(' %s="%s"', $key, htmlentities($value));

diff --git a/tests/Unit/ImageExtensionTest.php b/tests/Unit/ImageExtensionTest.php
@@ -382,6 +382,38 @@ public function testDefaultAttributes(): void
  );
  }
 
+ public function testRemoveDefaultAttributes(): void
+ {
+ $imageExtension = new ImageExtension(null, ['loading' => 'lazy']);
+
+ $this->assertSame(
+ '<img alt="Title" title="Description" src="/uploads/media/sulu-100x100/01/image.jpg?v=1-0">',
+ $imageExtension->getImage(
+ $this->image,
+ [
+ 'src' => 'sulu-100x100',
+ 'loading' => null,
+ ]
+ )
+ );
+ }
+
+ public function testReplaceLoadingAuto(): void
+ {
+ $imageExtension = new ImageExtension(null, ['loading' => 'lazy']);
+
+ $this->assertSame(
+ '<img alt="Title" title="Description" src="/uploads/media/sulu-100x100/01/image.jpg?v=1-0">',
+ $imageExtension->getImage(
+ $this->image,
+ [
+ 'src' => 'sulu-100x100',
+ 'loading' => 'auto',
+ ]
+ )
+ );
+ }
+
  public function testDefaultAttributesUnset(): void
  {
  $imageExtension = new ImageExtension(null, ['loading' => 'lazy']);