Add single_snippet_selection content type resolver #56
Conversation
|
Think later it would make sence to create a seperate PR to exclude functions like "getDefaultSnippetId" in own Service to reduce multiple code lines |
|
|
||
| $resolvedSnippet = $this->structureResolver->resolve($snippet, $locale, $loadExcerpt); | ||
|
|
||
| return new ContentView($resolvedSnippet, ['id' => $data]); |
There was a problem hiding this comment.
would you mind to adjust the existing SnippetSelectionResolver to use this format too? 🙂 (['ids' => ...]). then this would be consistent for the snippet selections
There was a problem hiding this comment.
Looks like we forget that when fixing #46 same should be done for the PageSelectionResolver and SinglePageSelectionResolver. Then I think all should be consistent.
There was a problem hiding this comment.
i guess it would also make sense to use that format in case there is no value set 🙂 for example here:
but we dont need to do this in this pull request
There was a problem hiding this comment.
sorry i'm not sure anymore :D should i change something more ?
There was a problem hiding this comment.
no - i will create a PR for the other resolvers 🙂
alexander-schranz
changed the title
alexander-schranz
added
the
Feature
|
Nice work - thanks a lot! |
See #3