adding synonyms for searching #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
approved these changes
Jul 15, 2024
|
Watch out for the flying lobsters @peetucket |
hudajkhan
commented
Jul 15, 2024
|
|
||
| sewerage,drains,manhole,manholes,sewage,sewer,sewerage,sewer-pipe,sewers | ||
|
|
||
| invertebrates,lobsters,mosquitoes,shellfish |
There was a problem hiding this comment.
@jcoyne and @peetucket , I can change this line so it's an expansion in one direction. I.e. invertebrates -> lobsters, mosquitoes, shellfish. This would prevent a search for mosquitoes to expand to a search for lobsters and vice versa.
There was a problem hiding this comment.
LOL, I don't really care. It's not my area of expertise. I just thought that it was silly.
There was a problem hiding this comment.
"The Flying Lobsters" is going to be the name of my steel drum band when I retire on Cape Cod.
|
any reason we can't merge? |
|
@dnoneill I think it's fine to merge. I'll put in another PR after testing some of this on staging to deal with the lobster situation. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request does:
Closes sul-dlss/earthworks#41 and relates to sul-dlss/earthworks#1083, we are adding a synonym file with added values and adding a synonym filter to the query analyzer for the "text_en" field type.