Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean css #1035

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Clean css #1035

merged 1 commit into from
Nov 9, 2023

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Nov 8, 2023 •
edited
Loading

Fixes #1019

@jcoyne jcoyne marked this pull request as draft November 8, 2023 22:15
@jcoyne jcoyne marked this pull request as ready for review November 9, 2023 02:30
jmartin-sul
jmartin-sul reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@jmartin-sul jmartin-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a Gemfile change too?

jmartin-sul
jmartin-sul approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jmartin-sul jmartin-sul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nm, must've gotten pulled in a prior commit (edit: yup)

@jmartin-sul jmartin-sul merged commit c619069 into main Nov 9, 2023
1 check passed
@jmartin-sul jmartin-sul deleted the clean-css branch November 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartin-sul jmartin-sul jmartin-sul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stacks/prod] RuntimeError: cssbundling-rails: Command install failed, ensure yarn is installed
2 participants
@jcoyne @jmartin-sul