Explicit initializer for StacksFile

sul-dlss · Jun 28, 2024 · b538ecb · b538ecb
1 parent 333defb
commit b538ecb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/controllers/file_controller.rb b/app/controllers/file_controller.rb
@@ -70,6 +70,6 @@ def cache_headers
   end
 
   def current_file
-    @file ||= StacksFile.new(file_params)
+    @file ||= StacksFile.new(id: params[:id], file_name: params[:file_name])
   end
 end
diff --git a/app/models/stacks_file.rb b/app/models/stacks_file.rb
@@ -4,10 +4,14 @@
 # Represents a file on disk in stacks. A StacksFile may be downloaded and
 # may be the file that backs a StacksImage or StacksMediaStream
 class StacksFile
-  include ActiveModel::Model
   include ActiveModel::Validations
 
-  attr_accessor :id, :file_name
+  def initialize(id:, file_name:)
+    @id = id
+    @file_name = file_name
+  end
+
+  attr_reader :id, :file_name
 
   validates :id, format: { with: StorageRoot::DRUID_PARTS_PATTERN }