Remove ocfl

.github/workflows/ruby.yml

@@ -30,5 +30,3 @@ jobs:
         run: bin/setup
       - name: Run tests
         run: bin/rake
-      - name: Run tests (with OCFL feature flag enabled)
-        run: SETTINGS__FEATURES__READ_STACKS_FROM_OCFL_ROOT=true bin/rake spec

Gemfile

@@ -76,7 +76,6 @@ gem 'retries'
 gem 'zipline', '~> 1.2'
 gem 'jwt'
 gem 'redis'
-gem 'ocfl'
 
 # connection_pool required for thread-safe operations in dalli >= 3.0
 # see https://github.com/petergoldstein/dalli/blob/v3.0.0/3.0-Upgrade.md

Gemfile.lock

@@ -147,42 +147,6 @@ GEM
     docile (1.4.0)
     domain_name (0.6.20240107)
     drb (2.2.1)
-    dry-configurable (1.1.0)
-      dry-core (~> 1.0, < 2)
-      zeitwerk (~> 2.6)
-    dry-core (1.0.1)
-      concurrent-ruby (~> 1.0)
-      zeitwerk (~> 2.6)
-    dry-inflector (1.0.0)
-    dry-initializer (3.1.1)
-    dry-logic (1.5.0)
-      concurrent-ruby (~> 1.0)
-      dry-core (~> 1.0, < 2)
-      zeitwerk (~> 2.6)
-    dry-monads (1.6.0)
-      concurrent-ruby (~> 1.0)
-      dry-core (~> 1.0, < 2)
-      zeitwerk (~> 2.6)
-    dry-schema (1.13.4)
-      concurrent-ruby (~> 1.0)
-      dry-configurable (~> 1.0, >= 1.0.1)
-      dry-core (~> 1.0, < 2)
-      dry-initializer (~> 3.0)
-      dry-logic (>= 1.4, < 2)
-      dry-types (>= 1.7, < 2)
-      zeitwerk (~> 2.6)
-    dry-struct (1.6.0)
-      dry-core (~> 1.0, < 2)
-      dry-types (>= 1.7, < 2)
-      ice_nine (~> 0.11)
-      zeitwerk (~> 2.6)
-    dry-types (1.7.2)
-      bigdecimal (~> 3.0)
-      concurrent-ruby (~> 1.0)
-      dry-core (~> 1.0)
-      dry-inflector (~> 1.0)
-      dry-logic (~> 1.4)
-      zeitwerk (~> 2.6)
     ed25519 (1.3.0)
     erubi (1.13.0)
     faraday (2.9.2)
@@ -210,7 +174,6 @@ GEM
     http-form_data (2.3.0)
     i18n (1.14.5)
       concurrent-ruby (~> 1.0)
-    ice_nine (0.11.2)
     iiif-image-api (0.2.0)
       activesupport
     io-console (0.7.2)
@@ -266,12 +229,6 @@ GEM
       racc (~> 1.4)
     nokogiri (1.16.6-x86_64-linux)
       racc (~> 1.4)
-    ocfl (0.9.1)
-      activesupport (>= 7.0)
-      dry-monads (~> 1.6)
-      dry-schema (~> 1.13)
-      dry-struct (~> 1.6)
-      zeitwerk (~> 2.0)
     okcomputer (1.18.5)
     parallel (1.25.1)
     parser (3.3.3.0)
@@ -470,7 +427,6 @@ DEPENDENCIES
   jbuilder (~> 2.7)
   jwt
   newrelic_rpm
-  ocfl
   okcomputer
   propshaft
   puma (~> 6.0)

app/models/storage_root.rb

@@ -35,7 +35,7 @@ def path_finder
   end
 
   def path_finder_class
-    Settings.features.read_stacks_from_ocfl_root ? OcflPathFinder : LegacyPathFinder
+    LegacyPathFinder
   end
 
   # Calculate file paths in the legacy Stacks structure
@@ -53,27 +53,4 @@ def absolute_path
       File.join(Settings.stacks.storage_root, relative_path)
     end
   end
-
-  # Calculate file paths in the OCFL structure
-  class OcflPathFinder
-    def initialize(druid:, file_name:, treeified_id:) # rubocop:disable Lint/UnusedMethodArgument
-      @druid = druid
-      @file_name = file_name
-    end
-
-    def relative_path
-      absolute_path.relative_path_from(Settings.stacks.ocfl_root)
-    end
-
-    def absolute_path
-      ocfl_object.path(filepath: @file_name)
-    end
-
-    private
-
-    def ocfl_object
-      storage_root = OCFL::StorageRoot.new(base_directory: Settings.stacks.ocfl_root)
-      storage_root.object(@druid)
-    end
-  end
 end

config/initializers/okcomputer.rb

@@ -17,9 +17,6 @@
 OkComputer::Registry.register 'stacks_mounted_dir',
   OkComputer::DirectoryCheck.new(Settings.stacks.storage_root)
 
-OkComputer::Registry.register 'stacks_ocfl_mounted_dir',
-                              OkComputer::DirectoryCheck.new(Settings.stacks.ocfl_root) if Settings.features.read_stacks_from_ocfl_root
-
 OkComputer::Registry.register 'purl_url', OkComputer::HttpCheck.new(Settings.purl.url + "status/default.json")
 
 OkComputer::Registry.register 'redis', OkComputer::RedisCheck.new(Settings.cdl.redis.to_h) if Settings.cdl.redis

config/settings.yml

@@ -1,11 +1,9 @@
 features:
   streaming_media: true
   metrics: false
-  read_stacks_from_ocfl_root: false
 
 stacks:
   storage_root: /stacks
-  ocfl_root: /stacks/ocfl
 
 imageserver:
   base_uri: "http://imageserver-prod.stanford.edu/iiif/2/"

config/settings/test.yml

@@ -11,8 +11,7 @@ user:
 features:
   metrics: true
 
-metrics_api_url: 'https://example.com'
+metrics_api_url: "https://example.com"
 
 stacks:
   storage_root: spec/fixtures
-  ocfl_root: spec/fixtures/ocfl