Embercli3compat #74
Open
Embercli3compat #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukima
approved these changes
Jul 11, 2019
| // Backwards compatability for Ember < 2.x | ||
| Ember.Enumerable.keys().indexOf('includes') !== -1 ? | ||
| // Backwards compatability for Ember < 2.x and > 3.x | ||
| (typeof ((Ember.A()).includes)) === 'function' ? |
There was a problem hiding this comment.
typeOf is an Ember function. I was using that over native one. This is a departure from the style used on line 11.
| // Backwards compatability for Ember < 2.x | ||
| Ember.Enumerable.keys().indexOf('includes') !== -1 ? | ||
| // Backwards compatability for Ember < 2.x and > 3.x | ||
| (typeof ((Ember.A()).includes)) === 'function' ? | ||
| 'includes' : | ||
| 'contains' |
There was a problem hiding this comment.
Oh I get it now. Gee this addon is really messy. Who wrote it? Oh right. now I'm embarrassed.
|
I'm not even going to begin understanding why CI fails. @directrix1 Adding you as a contributor. Merge when you feel this is working since your the one using the addon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error #73 .