-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added FAQ page #528
added FAQ page #528
Conversation
@pikurasa it follows the .MD workflow which we have discussed. |
Your changes to airspace.css go against a long term goal of using a theme without changes. See #305 Should your changes to the file be in another file? |
@therealharshit I think it would be wise to put that sort of CSS change into a new CSS file called custom.css Please make that change when you have the chance. |
@therealharshit It's not showing up for me in its current state: |
@pikurasa that's strange, please make some changes to FAQ.html so that it regenerate I think the html file needs regeneration to reflect changes. |
We've been tinkering around with gemfile and gemfile.lock, and I suspect this may have something to do with the issue. Can you upload those files -- not in your PR but -- as a .zip file here, please? |
gemfiles.zip |
I tried making a change to FAQ.html, but I still cannot see the FAQ on the page... Also, I wouldn't know why a manual change would be necessary, as it rebuilds when the branch is checked out. |
Interesting. Build is giving a warning, which may be preventing something from working. On the repository view, go to settings, then Pages, then where it says 'Last deployed by @pikurasa 5 hours ago" click on the deployed link; https://github.com/sugarlabs/www/actions/runs/11631167617 says "The github-pages gem can't satisfy your Gemfile's dependencies. If you want to use a different Jekyll version or need additional dependencies, consider building Jekyll site with GitHub Actions: https://jekyllrb.com/docs/continuous-integration/github-actions/" I don't know if it was saying this before the recent Gemfile changes. |
@therealharshit I was able to get it to work by removing However, I wonder, should we put custom JS into a different file as well (e.g. a new "custom.js" file) -- WDYT? |
@pikurasa custom.js sounds good, I'll put the js code in that file and update my PR. |
@pikurasa I have put the JS code in custom.js file and also linked it to base.html, please review. |
The page looks like this
Vedio:
FAQ-page.mp4
I have taken the FAQs from https://wiki.sugarlabs.org/go/Sugar_Labs/FAQ
@pikurasa please review.