Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added FAQ page #528

Merged
merged 3 commits into from
Nov 6, 2024
Merged

added FAQ page #528

merged 3 commits into from
Nov 6, 2024

Conversation

therealharshit
Copy link
Contributor

@therealharshit therealharshit commented Oct 28, 2024

The page looks like this
Vedio:

FAQ-page.mp4

I have taken the FAQs from https://wiki.sugarlabs.org/go/Sugar_Labs/FAQ

@pikurasa please review.

@therealharshit
Copy link
Contributor Author

@pikurasa it follows the .MD workflow which we have discussed.

@quozl
Copy link
Contributor

quozl commented Oct 28, 2024

Your changes to airspace.css go against a long term goal of using a theme without changes. See #305

Should your changes to the file be in another file?

@pikurasa
Copy link
Contributor

Should your changes to the file be in another file?

@therealharshit I think it would be wise to put that sort of CSS change into a new CSS file called custom.css

Please make that change when you have the chance.

@therealharshit
Copy link
Contributor Author

Your changes to airspace.css go against a long term goal of using a theme without changes. See #305

Should your changes to the file be in another file?

made the changes @pikurasa @quozl rather than changing airspace.css or creating a new CSS file, I have used bootstrap utility classes.

@pikurasa
Copy link
Contributor

@therealharshit It's not showing up for me in its current state:

Screenshot from 2024-10-28 22-16-45

@therealharshit
Copy link
Contributor Author

@pikurasa that's strange, please make some changes to FAQ.html so that it regenerate I think the html file needs regeneration to reflect changes.

@pikurasa
Copy link
Contributor

@pikurasa that's strange, please make some changes to FAQ.html so that it regenerate I think the html file needs regeneration to reflect changes.

We've been tinkering around with gemfile and gemfile.lock, and I suspect this may have something to do with the issue.

Can you upload those files -- not in your PR but -- as a .zip file here, please?

@therealharshit
Copy link
Contributor Author

gemfiles.zip
@pikurasa I have uploaded those files but I don't think it has something to do with this issue.
I also request you to please try my proposed solution which is to make some changes to FAQ.html so that it regenerate I think the html file needs regeneration to reflect these kind of changes.

@pikurasa
Copy link
Contributor

pikurasa commented Nov 1, 2024

I also request you to please try my proposed solution which is to make some changes to FAQ.html so that it regenerate I think the html file needs regeneration to reflect these kind of changes.

I tried making a change to FAQ.html, but I still cannot see the FAQ on the page...

Also, I wouldn't know why a manual change would be necessary, as it rebuilds when the branch is checked out.

@quozl
Copy link
Contributor

quozl commented Nov 1, 2024

Interesting. Build is giving a warning, which may be preventing something from working.

On the repository view, go to settings, then Pages, then where it says 'Last deployed by @pikurasa 5 hours ago" click on the deployed link;

https://github.com/sugarlabs/www/actions/runs/11631167617 says

"The github-pages gem can't satisfy your Gemfile's dependencies. If you want to use a different Jekyll version or need additional dependencies, consider building Jekyll site with GitHub Actions: https://jekyllrb.com/docs/continuous-integration/github-actions/"

I don't know if it was saying this before the recent Gemfile changes.

@pikurasa
Copy link
Contributor

pikurasa commented Nov 6, 2024

@therealharshit I was able to get it to work by removing --incremental flag when building.

However, I wonder, should we put custom JS into a different file as well (e.g. a new "custom.js" file) -- WDYT?

@therealharshit
Copy link
Contributor Author

@therealharshit I was able to get it to work by removing --incremental flag when building.

However, I wonder, should we put custom JS into a different file as well (e.g. a new "custom.js" file) -- WDYT?

@pikurasa custom.js sounds good, I'll put the js code in that file and update my PR.

@therealharshit
Copy link
Contributor Author

@pikurasa I have put the JS code in custom.js file and also linked it to base.html, please review.

@pikurasa pikurasa merged commit 7f137e8 into sugarlabs:master Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants