Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the navbar padding #391

Closed
wants to merge 1 commit into from
Closed

Fix the navbar padding #391

wants to merge 1 commit into from

Conversation

SrijanVerma04
Copy link

Fixes the content in the navbar with equal padding

@quozl
Copy link
Contributor

quozl commented Feb 12, 2023

Thanks, a nice simple change. Though I don't know why it works.

What do you think of #305? First commit in this repository was a 2017 Google Summer of Code project, which took airspace.css from what is now https://github.com/ndrewtl/airspace-jekyll and made some small changes. A diff between airspace-jekyll and that original airspace.css from 725368d shows a small degree of change. Since then we have tended to solve layout and formatting problems by tweaking this further. Your work on this pull request is another in that long sequence. Can you think of a way to bring our site back into a situation where we don't have to keep changing the upstream source code in airspace.css? Does it actually look okay with unmodified airspace.css and the other files? Should we be using a completely different Jekyll theme now?

@SrijanVerma04
Copy link
Author

Since I am very new to open source and contributing to the project and just fix the first issue which i think by changing some of the padding can solve the problem. Since appearance is also plays the big role for the website. And for using a different jekyll theme , i think i need to spend some more time before giving any of my opinion.
So with the guidance it will be helpful what to be done for the betterment of this project!!

@quozl
Copy link
Contributor

quozl commented Feb 13, 2023

Thanks. I don't mean a different theme, but the same one ... just without our customisation or derivation.

@SrijanVerma04
Copy link
Author

okay but for now i don't have any idea How this can be done but i will look into this.

@sugarlabs sugarlabs deleted a comment from PasunuriSrinidhi Apr 2, 2023
@quozl quozl closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants