Enhanced Profiles Page #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srevinsaju
approved these changes
Jan 15, 2022
|
Added review changes. As far as I can see, the profile layout wasn't used; can someone else please check for me? |
Agreed, I don't see it being used anywhere too. +1 for remove |
Bullet points apepared in navbar with 1ae8e43. * updated 'page title' and 'return to main-page', * made page responsive to geometry changes, * add title and last updated, * add return to main page link, * remove extra padding, * use similar font sizes, * remove unused profile layout.
|
Please use our guide to making commits and make sure the commit messages have the detail that you've been adding to the pull request. |
|
Sorry @quozl, I will be more careful next time.
In navbar in the "Join Us" dropdown, it's referred link present as "contributors" and also in the "SugarLabs" section in the footer named as "contributors". |
|
Yes, interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the problem in this. As shown in this Video.