Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed video #157

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Fixed video #157

merged 1 commit into from
Dec 4, 2017

Conversation

samswag
Copy link
Member

@samswag samswag commented Dec 4, 2017

Switched to Youtube

Switched to Youtube
@quozl quozl merged commit bec0936 into master Dec 4, 2017
@samswag
Copy link
Member Author

samswag commented Dec 4, 2017

  1. I fixed the video displaying problem by switching to youtube. Embedding one of our Youtube videos about Sugar Labs.

@quozl
Copy link
Contributor

quozl commented Dec 4, 2017

@samswag wrote:

  1. I fixed the video displaying problem by switching to youtube. Embedding one of our Youtube videos about Sugar Labs.

Yes, but it is too late to add anything to the commit, as the pull request is merged and closed now. In merging my edits to the commit message closed #108 and #148, and also referenced #94.

  1. I tried fixing the background image but it is not working. I am currently working on it.

Off-topic for this pull request, and doesn't help this pull request. Please either update issue #151 where it was mentioned, update issue #154 where it was mentioned, make a new issue (as #154 is a multiple issue issue), or find the pull request that caused the regression and click on Revert. 😸

@rhl-bthr rhl-bthr deleted the video-fixed branch July 7, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants