FastAPI Framework Setup Modification #9
Conversation
|
This looks like a duplicate of #7, if there's anything that's new here you can just push it there and close this, or close that one in favour of this as there's no need for two PRs by the same author addressing the same issue. |
|
@XXXJumpingFrogXXX you're yet to respond to any of my comments in this PR or #7. |
I have given a response to that |
|
Your opening comment should be part of your commit messages because git stores that, and that's what we care about. |
I will pay special attention to this in future commits and make sure my commit messages are more detailed and clear. Thank you for the reminder! |
|
You should also edit your current commit messages to include the details, |
(1) Created the latest main.py file and completed some basic FastAPI settings in it. (2) Renamed the original main.py file to original_main.py. (3) Kept the existing piggy directory and created a chat directory to establish separate routers and APIs for each project.
(1)Created a new main.py file: Established basic FastAPI settings to enhance application structure and scalability. This setup includes initial configurations and middleware setup, laying the groundwork for future development. (2)Renamed the original main.py: Changed to original_main.py to preserve the previous version and provide a reference for legacy code, facilitating a smooth transition and ensuring no loss of important historical context. (3)Refactored project structure: Maintained the existing piggy directory and introduced a chat directory. This separation of routers and APIs improves modularity, making it easier to manage and extend each project independently. These changes aim to improve code organization and prepare the project for scalable development with FastAPI.
XXXJumpingFrogXXX
force-pushed
the
fastapi
branch
from
332db65
to
c24a43f
Compare
|
I have updated the commit messages for the recent two PRs. |
| router = APIRouter() | ||
|
|
||
| @router.post("/generate_answer") | ||
| def generate_answer(value: Question): |
There was a problem hiding this comment.
This looks like an extended version of generate_bot_response in original_main.py below, if that's the case then you should delete that one as it was based on your draft PR to chat activity.
Also, does the prompt you've used here provide better responses than the one you used earlier?
There was a problem hiding this comment.
This looks like an extended version of
generate_bot_responseinoriginal_main.pybelow, if that's the case then you should delete that one as it was based on your draft PR to chat activity.Also, does the prompt you've used here provide better responses than the one you used earlier?
For the first question: This is not an extended version of generate_bot_response from original_main.py. This version utilizes the Unsloth library within Chat Activity and is significantly different from original_main.py. Additionally, we plan to remove the original_main.py file in the final modifications.
For the second question: Yes, the new prompt encourages the model to generate better responses.
There was a problem hiding this comment.
For the first question: This is not an extended version of generate_bot_response from original_main.py. This version utilizes the Unsloth library within Chat Activity and is significantly different from original_main.py. Additionally, we plan to remove the original_main.py file in the final modifications.
Yes it's significantly different from original_main.py, but it's achieving the same goal as that so generate_bot_response from original_main.py needs to be deleted to avoid duplicity.
There was a problem hiding this comment.
For the first question: This is not an extended version of generate_bot_response from original_main.py. This version utilizes the Unsloth library within Chat Activity and is significantly different from original_main.py. Additionally, we plan to remove the original_main.py file in the final modifications.
Yes it's significantly different from
original_main.py, but it's achieving the same goal as that so generate_bot_response from original_main.py needs to be deleted to avoid duplicity.
Oh, I agree! I will delete that!
There was a problem hiding this comment.
Thank you! Can you also start working on Kshitij's part? I think you can work with what he has so far.
Set up FastAPI and Refactor Project Structure
This PR includes the following changes:
These changes aim to improve code organization and prepare the project for scalable development with FastAPI.