Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pranshul #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pranshul #11

wants to merge 1 commit into from

Conversation

Pranshul-Thakur
Copy link

setup an error handling procedure in setup_vectorstore
also setup an error Handling in get_relevant_document
and added warning for missing files

@chimosky
Copy link
Member

There's no need to setup the error handling you're trying to setup, what did you notice when trying to test this and can you share steps to reproduce?

@Pranshul-Thakur
Copy link
Author

i added the error handling part for better clarity while trying to run it and the output i was getting it while trying it out was as follows
image
prior to this while running the original one, i kept getting undefined errors

@chimosky
Copy link
Member

An undefined errror could means the package import didn't work, maybe because you didn't have the dependency installed.

In the case of the image you've shared above - you could share text next time as that's clearer -, qa_chain is created on L109 before it's used anywhere.

@kshitijdshah99 can you reproduce this?

@Pranshul-Thakur
Copy link
Author

Pranshul-Thakur commented Nov 17, 2024

ok, i ll try reinstalling it all and doing it again, and get back one i got it working
and regarding the sharing the text, would sharing the entire text output suffice instead of an ss?

@kshitijdshah99
Copy link
Contributor

kshitijdshah99 commented Nov 17, 2024

An undefined errror could means the package import didn't work, maybe because you didn't have the dependency installed.

In the case of the image you've shared above - you could share text next time as that's clearer -, qa_chain is created on L109 before it's used anywhere.

@kshitijdshah99 can you reproduce this?

Yes even I feel the same maybe there's some issue with the dependencies or their inter-compatibility. Bcz when I had worked with with it the model was working great. It's the langchain dependencies that are causing this trouble.

@kshitijdshah99
Copy link
Contributor

qa_chain is created on L109 before it's used anywhere.

@kshitijdshah99 can you reproduce this?

You mean that I initialize the qa_chain only after the query comes in and the document is retrieved?

@Pranshul-Thakur
Copy link
Author

the undefined error was because of connection issue, sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants