FIXES #4070 The Pitch piemenu do not remember the last selected accidental value #4071
Conversation
|
|
||
| // Store the selected accidental in the block for later use. | ||
| prevAccidental = selection["attr"]; | ||
| block.prevAccidental = prevAccidental; |
There was a problem hiding this comment.
This retains the value during the session, but not between sessions. Maybe we need to think about saving/restoring this attribute with the block (much the way we do with the start block attributes).
There was a problem hiding this comment.
Like do you want the pitch block to save the data for last session like this @walterbender
There was a problem hiding this comment.
So what should I change in this pr regarding the issue @walterbender
There was a problem hiding this comment.
I think you don't need to change anything in what you have already done, but in this function in activity.js, this.prepareExport, you can see how some attributes are stored in the start block. We'll want to do something similar with the pitch block. And then restore the state on project import (in loadNewBlocks in blocks.js.
But maybe all that complexity can be dealt with in a separate PR. Let me test this code as is.
There was a problem hiding this comment.
Okay @walterbender i ll make a new PR in regards to these changes and will resolve soon.
|
Hmm. One problem. It does remember the accidental selection, but when I leave the pie menu the 2nd time, it does not display the accident in the pitch block.
|
|
@walterbender yaa i see this issue will make it resolved soon |
fixing issue #4070
Now the pitch piemenu remembers the last selected accidental value
custom pitch selected ;
the wheel represents the same value as selected ;