[3851] - feature: exit the user from collaboration on New Project and Load project from file events
#4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlabs#3924) * fix:resolves hamburger opening(sugarlabs#3914) * fix:fixes sugarlabs#3914(suggested changes done) * adjust size of grid element repositioning when using aux toolbar --------- Co-authored-by: Walter Bender <[email protected]>
Co-authored-by: anas2357 <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [gulp](https://github.com/gulpjs/gulp). These dependencies need to be updated together. Updates `braces` from 2.3.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](https://github.com/micromatch/braces/commits/3.0.3) Updates `gulp` from 4.0.2 to 5.0.0 - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.0) --- updated-dependencies: - dependency-name: braces dependency-type: indirect - dependency-name: gulp dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add support for cents through semi-tone transposition * add 50 cents macro * add cents example * add output frequencies * fix issue with ratio cents * add a ratio-cents example
* use processPitch for all pitch types * Add support for cents (sugarlabs#3937) * add support for cents through semi-tone transposition * add 50 cents macro * add cents example * add output frequencies * fix issue with ratio cents * add a ratio-cents example * use processPitch for all pitch types * convert freq to note before scalar step
* Update README.md * Update dockerfile
…tion call, add uses export statements for BACKWARDCOMPATIBILIYDICT and initBasicProtoBlocks, instead of comments to indicate exports (sugarlabs#3994)" This reverts commit a6f3514.
* move all saved state into a single object, remove unnecessarya variable declarations * re-add some variable names to avoid breaking code, and remove singer.notesPlayed
* update PitchBlocks.js * update ProgramBlocks.js * update VolumeBlocks.js * update WidgetBlocks.js * update IntervalsActions.js * update PitchActions.js * update RhythmActions.js * update ToneActions.js * update VolumeActions.js * update utils.js * update arpeggio.js * update musickeyboards.js * update phrasemaker.js * update rhythmruler.js * update generate.js * update interface.js * update mathutils.js * update synthutils.js * update help.js * update helper.js
* clean code , added comments * added abc lib * added debug statement * fix : Formatting , Function method & method Func * add function description --------- Co-authored-by: Walter Bender <[email protected]>
…bs#3813) * added recording and playback button * upd * added recording started,completed msg and button disabled when no url * updated icons * added sample for waveform * upd * added the required changes,play sample pitch,create sample with setinstrument
… Converts to 'Unknown' Block (sugarlabs#4006) By this commit the set default instrument block is working fine.
…ugarlabs#3999) * Added RUN LIVE option * Added RUN LIVE option * Added new RUN LIVE links
…ect lookup (sugarlabs#4008) * drum returns quicker post http match, use object lookup instead of a for loop * add value matches
…garlabs#4010) * Updating musicutils.js in order to change the name of the temperament name list FIXES ISSUE sugarlabs#3921 Reexamine our default temperament list * Updating piemenus.js FIXES ISSUE sugarlabs#3921 Reexamine our default temperament list In order to fix all the names perfectly in the menu i increased the size of the basic pie menu for the temperament name block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #3851
This PR implements functionality to exit the user from the collaboration room when they click either initiate a new project or load another project from the file. Also, I have considered clearing all the mouses from the disconnected client.
Here is the demo:
2024-09-26.17-10-08.mp4