musickeyboard.js: Enhanced the UI on maximizing the musickeyboard widget and fix bugs. #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Please review @meganindya. |
|
There is a WIP on this widget: #2826. I'm converting this to draft for now. |
daksh4469
changed the title
|
Hi @meganindya, the PR #2826 has now been closed. So can I now mark this Ready for Review? |
|
@daksh4469 regressions are being addressed.. working with @ksraj123 to obviate them...will re-open/issue a new PR soon thought, it'd be imperative to inform..thanks |
|
Thanks to bring that to notice. @ricknjacky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference: #2767, #2808
This PR improves the UI and fixes some bugs in the music keyboard widget.
Firstly, there is an unnecessary scroll bar present (as shown below) on the right-most side of the widget which can be removed without any issues.
Secondly, the main issue was on maximizing this widget, as on maximizing it there was plenty of space left which was unused but could be used for a better User Experience. This PR enables this widget to enlarge the note matrix on maximizing, so as to take full advantage of a full screen.
Before:
screen-capture.4.mp4
After: (without the right-most scroll bar as mentioned above)
screen-capture4.mp4