js/turtleactions: refactor, lint & prettify

[ricknjacky]

issue references: #2609, #2767

[ricknjacky]

@meganindya pls review this.

[ksraj123]

It would be more helpful if we had where the globals come from in the same file. I think the reason behind enabling linting was that we could identify and fix other issues in the process. I guess, fixing linting issues in a way that just make the errors go away is as good as not having linting at all. Just my humble opinion. Thanks

[ricknjacky]

It would be more helpful if we had where the globals come from in the same file. I think the reason behind enabling linting was that we could identify and fix other issues in the process. I guess, fixing linting issues in a way that just make the errors go away is as good as not having linting at all. Just my humble opinion. Thanks

Totally agree. But that's not what I did.
With the nascent experience I have of working on the codebase, I have addressed your concerns.
Also,

Core of MusicBlocks resides in the /js, /blocks and the /turtleactions subdirectories. As a result there are many globals in these directories, js/turtleactions in this case. There are architectural issues pertaining to this as well, hopefully in MB2 we can obviate this instead of having this galore of GOD objects engendering regressions and all sorts of other issues.

Thanks a lot for the review btw

[ksraj123]

@meganindya Please go through my comments in my review which have been marked as resolved. I was working on some other issue that involved one of the files in this PR so I thought reviewing this would be a good opportunity to learn. Thanks

[ricknjacky]

@ksraj123 Thx for pointing out your concerns. I have unresolved your comments on the review, waiting for better answers to these. Surely it's a great opportunity to learn more about how the codebase is inter-connected.

[meganindya]

Add the locations too

/*
   Global locations
    path..
        .., .., ...
 */

[ricknjacky]

Thanks for pointing out my mistakes and sharing your feedback @meganindya

[ricknjacky]

Where is args?

static defineMode(name, turtle, blk) {
            const tur = logo.turtles.ithTurtle(turtle);

            tur.singer.inDefineMode = true;
            tur.singer.defineMode = [];
            let modeName;
            if (name === null) {
                logo.errorMsg(NOINPUTERRORMSG, blk);
                modeName = "custom";
            } else {
                modeName = args[0].toLowerCase();
            }

[ricknjacky]

blk must have been passed to the methods from corresponding classes in /blocks. If it isn't that's an error. Certainly not a global.

@meganindya
I have removed the argument blk and _blk accordingly.

Pls review and provide feedback, thanks.