Fix Bug in Arbitrary Edit Tab and improvements in Tempo Widget. #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review this PR @meganindya. |
meganindya
reviewed
Feb 5, 2021
| docById("wheelDiv3").addEventListener("mouseover", (e) => { | ||
| this.arbitraryEditSlider(e, angle1, ratios, pitchNumber); | ||
| }); | ||
| },1500); |
There was a problem hiding this comment.
How did you decide on this value: 1500ms?
There was a problem hiding this comment.
Through trial and error.
I tried reducing 50ms from 2000ms and on the 1400ms mark, I felt it could show the "noteInfo" just before the whole animation could complete.
Thus, decided on the value of 1500ms.
daksh4469
changed the title
|
Is there any issue with this PR? @meganindya |
meganindya
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference: #2767
In the Arbitrary Tab of the Add Pitches section in the Temperament Widget, I noticed that once if you hover on the outer circle before the animation is completed, it remains incomplete forever.
Before:
before.mp4
So, I just added a Timeout on the event listener of mouseover event so that it activates only after the animation is completed.
After:
after.mp4
Also, in the Tempo widget, it showed "Play" on the Pause button and vice-versa.
This was fixed in this PR.
Finally, there was no error shown on clicking the down button when the BPM is 30 or clicking the speed up button when the BPM is 1000.
Thus, I added an error message showing the subsequent errors:
For BPM=30 and clicking the down button:
For BPM=1000 and clicking the speed up button: