Temperament BugFix and ES6+ port

[ricknjacky]

Issue reference:- #2767, #2630, #2609

Bug:-

When stop button is pressed, temperament widget continues to play the previous value of the pitch in conjunction to the pitch values from the start. Notice the erratic behavior in the video below.

Temprament-1.mp4

Obviation of bug post fixes:-

Temprament2.mp4

Post port, the behavior of rest of functionalities of the temperament widget:-

Temprament3.mp4

As is, this port didn't produce any errors for me on my system locally, however if any error/erratic behavior is produced due to this port, do let me know. Thanks

[ricknjacky]

@meganindya please review this.

[meganindya]

The bug is fixed but I can spot a few other crashes using some of the UI buttons in the widget. Please check.

temperament.js:1946 Uncaught TypeError: Cannot set property 'fillAttr' of undefined
    at __playLoop (temperament.js:1946)
    at temperament.js:2056

temperament.js:862 Uncaught ReferenceError: ratios is not defined
    at TemperamentWidget.performEqualEdit (temperament.js:862)
    at HTMLDivElement.<anonymous> (temperament.js:761)

[ricknjacky]

The bug is fixed but I can spot a few other crashes using some of the UI buttons in the widget. Please check.

Thankyou for the feedback. I have rectified my errors:-
Post FIX behavior of UI buttons:-

Temprament-UI-Fixes.mp4

[ricknjacky]

@meganindya In ad5bb2b I have added some of the JSDoc content. If this is fine by you, I'll add JSDoc styling comments for the entire file.
Looking forward to hear from you, Thanks.

[meganindya]

Yeah pls do. I've fixed the linting errors and formatted the code. If possible, add a global locations comment like @ksraj123 has been doing (could be narrower with the whitespaces though) and remove dirty code if any.

[ricknjacky]

Yeah pls do. I've fixed the linting errors and formatted the code. If possible, add a global locations comment like @ksraj123 has been doing (could be narrower with the whitespaces though) and remove dirty code if any.

Did the necessary changes. Any corrections?

[meganindya]

I clustered your commits and formatted the code. However, the widget shows anomalous behavior. Last time it was alright. Please check.

[ricknjacky]

I clustered your commits and formatted the code.

Thanks

However, the widget shows anomalous behavior. Last time it was alright. Please check.

Tested again:-

Temp-Test.mp4

This time even with formatting changes that you have done, I did not encounter any error, can you please describe the anomalous behavior?

[meganindya]

Can't reproduce it again.