Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightwatch in favour of puppeteer #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jalkoby
Copy link

@jalkoby jalkoby commented Nov 29, 2017

Hey there.
I'd added the library to my project and it'd worked well, so I decided to make a little contribution as a favour. I see that you've been having a problem with tests, so I reworked them and replace with a more stable puppeteer. Only before the commit I noticed that there is a multi browser env, so the change will cut it and stick with Chrome only. Probably you will reject it and this is fine, it's your project. But nothing wrong is to make a shot at least

@sudodoki
Copy link
Owner

First of all, thanks for contribution!
Tests won't pass on travis - issue with clipboardy dependency, possibly can be solved by adding sudo apt install xsel to travis setup step
Tests working exclusively on Chrome are better than no tests at all, I guess, although main issue with this library was different behaviour across the browsers (like extra new lines in FF that I found after initially setting up saucelabs tests / etc) - so I would gladly merge this if you could make it work on travis

@jalkoby jalkoby force-pushed the master branch 4 times, most recently from eed7787 to 11d8153 Compare November 29, 2017 21:02
@jalkoby
Copy link
Author

jalkoby commented Nov 30, 2017

running xsel on travis ci is hard. I made a few changes, so currently I got 1 pass & 3 fails. Need more time to figure out how it should be configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants