Supporting IP or Hostname #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change associated with bug #27 |
|
Would you mind rebasing the PR to go to the setup-ports branch? (you can confusingly do so by pressing the edit button in the top right of this page) That's currently where all new features live Other than that, LGTM PS: The X button on the keyboard doesn't do anything as the keyboard cannot really dissapear ;) |
matthawley
force-pushed
the
ip-or-hostname
branch
from
1e15f40 to
a1e0fdd
Compare
|
Alright, rebased and changed upstream branch. I also set it up to use 2 different keyboards so that the ip/hostname can use the custom keyboard and the port will use the number keyboard. |
matthawley
force-pushed
the
ip-or-hostname
branch
from
9492708 to
d41a059
Compare
matthawley
force-pushed
the
ip-or-hostname
branch
from
49f4314 to
f2d4121
Compare
|
:D I royally screwed something up. I'll be re-creating this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the keyboard during the "ip" setup to also support a hostname entry instead. It uses a custom keyboard allowing for the characters
0-9,a-z,-and..Build can be tested using https://github.com/matthawley/CYD-Klipper/actions/runs/7771755561